-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new resource to manage group LDAP links #296
Conversation
@jasoncarlsen if you could also document the new resource, I will merge your contribution. Please add it in the |
…ests and a test data template for defining real LDAP data.
@ringods Thanks for the feedback, I've added documentation as requested. Please let me know if I need to change anything else. |
@jasoncarlsen at first sight this looks fine. Tnx for the work you did in this contribution. |
@jasoncarlsen after the merge, the acceptance tests of the Community Edition fail. One of the lines is regarding the LDAP link. Can you have a look and verify whether this is related or not? https://github.com/terraform-providers/terraform-provider-gitlab/runs/710870254 |
@ringods I took a look and the test is behaving as expected. There are two things to keep in mind with this test:
|
@jasoncarlsen If the test should be skipped on CE, could you submit an additional PR where you use See here for an example: |
Adding new resource to manage group LDAP links
Closes #183